Chromium Code Reviews| Index: components/password_manager/core/browser/password_form_manager.cc |
| diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc |
| index 5f7d21fe499d74f674d9b1950df562abe54acdb1..28987209ed9f18dd4dfdaa91379e3491fedeb898 100644 |
| --- a/components/password_manager/core/browser/password_form_manager.cc |
| +++ b/components/password_manager/core/browser/password_form_manager.cc |
| @@ -7,8 +7,10 @@ |
| #include <algorithm> |
| #include "base/metrics/histogram.h" |
| +#include "base/metrics/user_metrics.h" |
| #include "base/strings/string_split.h" |
| #include "base/strings/string_util.h" |
| +#include "base/strings/utf_string_conversions.h" |
| #include "components/autofill/core/browser/autofill_manager.h" |
| #include "components/autofill/core/browser/form_structure.h" |
| #include "components/autofill/core/browser/validation.h" |
| @@ -533,6 +535,13 @@ void PasswordFormManager::UpdateLogin() { |
| // Update metadata. |
| ++pending_credentials_.times_used; |
| + if (client_->IsPasswordSyncAccountCredential( |
|
vabr (Chromium)
2014/07/01 08:52:00
Should this signal also be in PasswordFormManager:
Garrett Casto
2014/07/04 07:27:49
If we are saving a new password then the credentia
vabr (Chromium)
2014/07/04 15:53:15
Ah, right, thanks for explaining that to me.
|
| + UTF16ToUTF8(pending_credentials_.username_value), |
| + pending_credentials_.signon_realm)) { |
| + base::RecordAction( |
| + base::UserMetricsAction("PasswordManager_SyncCredentialUsed")); |
| + } |
| + |
| // Check to see if this form is a candidate for password generation. |
| CheckForAccountCreationForm(pending_credentials_, observed_form_); |