Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 355143006: [Password Manager] Add UMA stats to track interaction with synced accounts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index 2605f85621ca409e7185391560957037312a13f2..d6400c7fd4cfe485dc8053a4a3ab4c84e1bc9509 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -78,8 +78,10 @@ PasswordStore::PasswordStore(
observers_(new ObserverListThreadSafe<Observer>()),
shutdown_called_(false) {}
-bool PasswordStore::Init(const syncer::SyncableService::StartSyncFlare& flare) {
- ReportMetrics();
+bool PasswordStore::Init(const syncer::SyncableService::StartSyncFlare& flare,
+ const std::string& sync_username,
+ enum SyncState sync_state) {
+ ReportMetrics(sync_username, sync_state);
#if defined(PASSWORD_MANAGER_ENABLE_SYNC)
ScheduleTask(base::Bind(&PasswordStore::InitSyncableService, this, flare));
#endif
@@ -162,8 +164,10 @@ void PasswordStore::GetBlacklistLogins(PasswordStoreConsumer* consumer) {
Schedule(&PasswordStore::GetBlacklistLoginsImpl, consumer);
}
-void PasswordStore::ReportMetrics() {
- ScheduleTask(base::Bind(&PasswordStore::ReportMetricsImpl, this));
+void PasswordStore::ReportMetrics(const std::string& sync_username,
+ enum SyncState sync_state) {
+ ScheduleTask(base::Bind(&PasswordStore::ReportMetricsImpl, this,
+ sync_username, sync_state));
}
void PasswordStore::AddObserver(Observer* observer) {

Powered by Google App Engine
This is Rietveld 408576698