[Password Manager] Add UMA stats to track interaction with synced accounts.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8ff2149da299371b8e7d69b6f9ac6c98c35cbb70..8497f89fd55823c6dc4885e9076e1481e2a9f646 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19003,6 +19003,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.PasswordSyncAccountTimesUsed">
+  <owner>gcasto@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Number of times a users has used the password for their sync account if they

[Ilya Sherman, 2014/06/27 19:37:52]

nit: "a users" -> "a user"

[Garrett Casto, 2014/06/27 21:07:34]

Done.

+    are syncing passwords.

[Ilya Sherman, 2014/06/27 19:37:51]

Please document when this is recorded.  Also, the number of times the user has
used the password since when?

[Garrett Casto, 2014/06/27 21:07:35]

Done.

+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.ProvisionalSaveFailure"
     enum="ProvisionalSaveFailure">
   <owner>dubroy@chromium.org</owner>
@@ -19052,6 +19061,26 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.SyncAccountTimesUsed">

[Ilya Sherman, 2014/06/27 19:37:51]

It would be nice to give this histogram (more of) a shared prefix with the one
currently named "PasswordManager.PasswordSyncAccountTimesUsed", so that the two
are adjacent in the dashboard.

[Garrett Casto, 2014/06/27 21:07:34]

Done.

+  <owner>gcasto@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Number of times a users has used the password for their sync account. Note
+    that this only histogram only tracks users that are enrolled in sync, but
+    not password sync.

[Ilya Sherman, 2014/06/27 19:37:51]

Same comments as above.  Also, "only histogram only" -> "histogram only".

[Garrett Casto, 2014/06/27 21:07:35]

Done.

+  </summary>
+</histogram>
+
+<histogram name="PasswordManager.SyncingAccountState"
+    enum="PasswordManagerSyncingAccountState">
+  <owner>gcasto@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Information about the users current sync status crossed with if their synced

[vabr (Chromium), 2014/06/27 10:44:14]

typo: users -> user's

[Garrett Casto, 2014/06/27 21:07:34]

Done.

+    password is saved or not.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.TimesGeneratedPasswordUsed">
   <owner>dubroy@chromium.org</owner>
   <owner>vabr@chromium.org</owner>
@@ -43255,6 +43284,28 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="2" label="Match"/>
 </enum>
 
+<enum name="PasswordManagerSyncingAccountState" type="int">
+  <summary>
+    The value is a combination of the current sync state and if the user has
+    their sync password saved.
+  </summary>
+  <int value="0" label="User is not syncing."/>
+  <int value="1"
+      label="User is not syncing, but has their sync password store. This

[vabr (Chromium), 2014/06/27 10:44:14]

typo: store -> stored

[Garrett Casto, 2014/06/27 21:07:35]

Done.

+             value should not happen."/>

[Ilya Sherman, 2014/06/27 19:37:51]

These are very long labels, which will not be very readable on the dashboard. 
I'd recommend using briefer labels, and optionally adding description="..."
attributes -- which are shown on mouse hover -- if you think it's useful.

[Garrett Casto, 2014/06/27 21:07:34]

Shortened.

+  <int value="2"
+      label="User is syncing some state, but not passwords, but does not have
+             their sync account saved."/>
+  <int value="3"
+      label="User is syncing some state, but not passwords, and has their
+             sync account saved."/>
+  <int value="4"
+      label="User is syncing passwords but does not have their sync their

[vabr (Chromium), 2014/06/27 10:44:14]

typo: "their sync their sync"

[Garrett Casto, 2014/06/27 21:07:34]

Done.

+             sync account saved."/>
+  <int value="5"
+      label="User is syncing passwords and has their sync account saved."/>
+</enum>
+
 <enum name="PasswordManagerUIDismissalReason" type="int">
   <int value="0" label="Bubble lost focus / No infobar interaction"/>
   <int value="1" label="Clicked 'Save'"/>