tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8ff2149da299371b8e7d69b6f9ac6c98c35cbb70..08549a07568969e4b6ab72c2f58604aecf5825f9 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19052,6 +19052,39 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.SyncAccountWithoutPasswordsTimesUsed">
+  <owner>gcasto@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Number of times a users has used the password for their sync account. Note
+    that this histogram only tracks users that are enrolled in sync, but not
+    password sync. Recorded on browser startup. Any usage before M29 is not
+    included. Any usage before M36 may not be properly accounted if it was on a
+    different profile.
+  </summary>
+</histogram>
+
+<histogram name="PasswordManager.SyncAccountWithPasswordsTimesUsed">
+  <owner>gcasto@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Number of times a user has used the password for their sync account if they
+    are syncing passwords. Recorded on browser startup. Any usage before M29 is
+    not included. Usage before M36 may not be properly accounted if it was on a
+    different profile.
+  </summary>
+</histogram>

[Ilya Sherman, 2014/07/01 19:46:21]

Hmm, do you still need these two metrics, now that you've added the action and
are planning to write custom server-side scripts?  I'm concerned that these
metrics will be very hard to use, and hence either of ver low value, or possibly
even of negative value if somebody tries to use them without deeply
understanding what biases can contribute here.

[Garrett Casto, 2014/07/04 07:27:49]

Whoops, removed from the code but forgot to remove here. Done.

+
+<histogram name="PasswordManager.SyncingAccountState"
+    enum="PasswordManagerSyncingAccountState">
+  <owner>gcasto@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Information about the user's current sync status crossed with if their

[Ilya Sherman, 2014/07/01 19:46:21]

nit: IMO "crossed with if" -> "crossed with whether" (and you could probably
drop the "or not" at the end of the sentence).

[Garrett Casto, 2014/07/04 07:27:49]

Done.

+    synced password is saved or not.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.TimesGeneratedPasswordUsed">
   <owner>dubroy@chromium.org</owner>
   <owner>vabr@chromium.org</owner>
@@ -43255,6 +43288,18 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="2" label="Match"/>
 </enum>
 
+<enum name="PasswordManagerSyncingAccountState" type="int">
+  <summary>
+    The value is a combination of the current sync state and if the user has
+    their sync password saved.
+  </summary>
+  <int value="0" label="User is not syncing."/>

[Ilya Sherman, 2014/07/01 19:46:21]

nit: I'd write this label as "Not Syncing" to match the format of the other
labels.

[Garrett Casto, 2014/07/04 07:27:49]

Done.

+  <int value="1"
+      label="Not Syncing/Pasword saved. This value should not happen."/>

[Ilya Sherman, 2014/07/01 19:46:21]

nit: I'd use either "Sync password" or "Password" consistently throughout.

[Garrett Casto, 2014/07/04 07:27:49]

Done.

+  <int value="2" label="Syncing/Sync password not saved"/>
+  <int value="3" label="Syncing/Sync password saved"/>
+</enum>
+
 <enum name="PasswordManagerUIDismissalReason" type="int">
   <int value="0" label="Bubble lost focus / No infobar interaction"/>
   <int value="1" label="Clicked 'Save'"/>