Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 354973002: Simplify very outdated core.gyp file list filtering (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
brettw, abarth-chromium
CC:
blink-reviews, brettw, eseidel
Project:
blink
Visibility:
Public.

Description

Simplify very outdated core.gyp file list filtering The gyp build for core does some strange things put in place in ancient times to fix ancient problems. There's no need nowadays to: *) list all core svg files in both webcore_files and webcore_svg_files only to filter the webcore_files entries with a regex *) exclude 'opentype', 'cf', etc files from core with a regex *) exclude platform-specific directories in core - we've moved all that to Source/platform These funky rules are hard to maintain in gyp and impossible to do so in GN, so let's get rid of them. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M Source/core/core.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
Brett - fyi this should fix a lot of duplicate symbol errors inside blink
6 years, 6 months ago (2014-06-26 06:14:19 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-26 06:33:29 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-26 06:55:20 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-26 06:56:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/354973002/1
6 years, 6 months ago (2014-06-26 06:59:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 13:02:52 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-06-27 13:02:53 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-06-27 15:39:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/354973002/1
6 years, 5 months ago (2014-06-27 15:40:03 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 16:48:20 UTC) #10
Message was sent while issue was closed.
Change committed as 177114

Powered by Google App Engine
This is Rietveld 408576698