Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/core.gyp

Issue 354973002: Simplify very outdated core.gyp file list filtering (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/core.gyp
diff --git a/Source/core/core.gyp b/Source/core/core.gyp
index 1d6d0c620653127b571bb555ba9d579ded1b187a..e1f9c5f1c6e608f7dbce76540faf968bb67ec969 100644
--- a/Source/core/core.gyp
+++ b/Source/core/core.gyp
@@ -598,8 +598,6 @@
['exclude', '.*'],
['include', 'rendering/'],
- # FIXME: Figure out how to store these patterns in a variable.
- ['exclude', '(cf|cg|mac|opentype|svg|win)/'],
['exclude', '(?<!Chromium)(CF|CG|Mac|Win)\\.(cpp|mm?)$'],
# Previous rule excludes things like ChromiumFooWin, include those.
['include', 'rendering/.*Chromium.*\\.(cpp|mm?)$'],
@@ -675,8 +673,6 @@
'sources/': [
['exclude', 'rendering/'],
- # FIXME: Figure out how to store these patterns in a variable.
- ['exclude', '(cf|cg|mac|opentype|svg|win)/'],
['exclude', '(?<!Chromium)(CF|CG|Mac|Win)\\.(cpp|mm?)$'],
],
'conditions': [
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698