Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 3549010: Fix raw_scoped_refptr_mismatch_checker.h. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Fix raw_scoped_refptr_mismatch_checker.h. BUG=28083 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69237

Patch Set 1 #

Patch Set 2 : Comments. #

Total comments: 2

Patch Set 3 : Addressed jamesr's comments. #

Patch Set 4 : Fix test suites. #

Patch Set 5 : Oops, wrong branch :P #

Patch Set 6 : Merge #

Patch Set 7 : Disable on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -141 lines) Patch
M base/callback.h View 1 chunk +3 lines, -2 lines 0 comments Download
M base/raw_scoped_refptr_mismatch_checker.h View 1 2 3 4 5 6 1 chunk +92 lines, -133 lines 0 comments Download
M base/task.h View 1 2 3 4 5 3 chunks +9 lines, -6 lines 0 comments Download
M base/template_util.h View 1 2 3 4 5 6 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
willchan no longer on Chromium
This isn't ready to land yet because I have to fix all the compile errors. ...
10 years, 2 months ago (2010-10-01 23:02:18 UTC) #1
darin (slow to review)
I defer completely to James on this one.
10 years, 2 months ago (2010-10-01 23:07:47 UTC) #2
jamesr
LGTM. Good luck landing this without bustage :) http://codereview.chromium.org/3549010/diff/2001/3004 File base/template_util.h (right): http://codereview.chromium.org/3549010/diff/2001/3004#newcode17 base/template_util.h:17: }; ...
10 years, 2 months ago (2010-10-01 23:10:18 UTC) #3
willchan no longer on Chromium
10 years, 2 months ago (2010-10-01 23:25:48 UTC) #4
Thanks for the review.  Yeah, I'll probably break something.  So it goes.

http://codereview.chromium.org/3549010/diff/2001/3004
File base/template_util.h (right):

http://codereview.chromium.org/3549010/diff/2001/3004#newcode17
base/template_util.h:17: };
Done.

On 2010/10/01 23:10:18, jamesr wrote:
> should these go into the internal namespace?
> 
> why isn't big_ defined:
> 
> struct big_ {
>   small_ dummy[2];
> };

Powered by Google App Engine
This is Rietveld 408576698