Chromium Code Reviews
Help | Chromium Project | Sign in
(23)

Issue 3549010: Fix raw_scoped_refptr_mismatch_checker.h. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by willchan
Modified:
2 years, 11 months ago
CC:
chromium-reviews_chromium.org, brettw-cc_chromium.org, cbentzel+watch_chromium.org, PaweĊ‚ Hajdan Jr., darin-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Fix raw_scoped_refptr_mismatch_checker.h.

BUG=28083
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69237

Patch Set 1 #

Patch Set 2 : Comments. #

Total comments: 2

Patch Set 3 : Addressed jamesr's comments. #

Patch Set 4 : Fix test suites. #

Patch Set 5 : Oops, wrong branch :P #

Patch Set 6 : Merge #

Patch Set 7 : Disable on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -141 lines) Lint Patch
M base/callback.h View 1 chunk +3 lines, -2 lines 0 comments 0 errors Download
M base/raw_scoped_refptr_mismatch_checker.h View 1 2 3 4 5 6 1 chunk +92 lines, -133 lines 0 comments ? errors Download
M base/task.h View 1 2 3 4 5 3 chunks +9 lines, -6 lines 0 comments ? errors Download
M base/template_util.h View 1 2 3 4 5 6 2 chunks +47 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
willchan
This isn't ready to land yet because I have to fix all the compile errors. ...
3 years, 6 months ago #1
darin
I defer completely to James on this one.
3 years, 6 months ago #2
jamesr (out of office)
LGTM. Good luck landing this without bustage :) http://codereview.chromium.org/3549010/diff/2001/3004 File base/template_util.h (right): http://codereview.chromium.org/3549010/diff/2001/3004#newcode17 base/template_util.h:17: }; ...
3 years, 6 months ago #3
willchan
3 years, 6 months ago #4
Thanks for the review.  Yeah, I'll probably break something.  So it goes.

http://codereview.chromium.org/3549010/diff/2001/3004
File base/template_util.h (right):

http://codereview.chromium.org/3549010/diff/2001/3004#newcode17
base/template_util.h:17: };
Done.

On 2010/10/01 23:10:18, jamesr wrote:
> should these go into the internal namespace?
> 
> why isn't big_ defined:
> 
> struct big_ {
>   small_ dummy[2];
> };
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6