Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 354613002: Add test to track the number of hit tests on various events (Closed)

Created:
6 years, 6 months ago by Rick Byers
Modified:
6 years, 5 months ago
Reviewers:
esprehn
CC:
arv+blink, blink-reviews, blink-reviews-rendering, Inactive, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, watchdog-blink-watchlist_google.com, Zeeshan Qureshi, zoltan1
Project:
blink
Visibility:
Public.

Description

Add test to track the number of hit tests on various events BUG=381728 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177028

Patch Set 1 #

Patch Set 2 : Fix scroll offset #

Patch Set 3 : Fix upload #

Patch Set 4 : Merge with trunk #

Total comments: 12

Patch Set 5 : Apply CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -0 lines) Patch
A LayoutTests/fast/events/hit-test-counts.html View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/hit-test-counts-expected.txt View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rick Byers
esprehn@ can you review please? I figured I'd land this in advance of the series ...
6 years, 6 months ago (2014-06-24 20:54:35 UTC) #1
esprehn
I would have just made script do the subtractions, but you can also just add ...
6 years, 6 months ago (2014-06-26 02:33:50 UTC) #2
Rick Byers
Thank Elliott. https://codereview.chromium.org/354613002/diff/60001/LayoutTests/fast/events/hit-test-counts.html File LayoutTests/fast/events/hit-test-counts.html (right): https://codereview.chromium.org/354613002/diff/60001/LayoutTests/fast/events/hit-test-counts.html#newcode2 LayoutTests/fast/events/hit-test-counts.html:2: <body onload=run()> On 2014/06/26 02:33:50, esprehn wrote: ...
6 years, 6 months ago (2014-06-26 15:35:18 UTC) #3
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 6 months ago (2014-06-26 16:15:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/354613002/80001
6 years, 6 months ago (2014-06-26 16:16:59 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-26 23:43:33 UTC) #6
Message was sent while issue was closed.
Change committed as 177028

Powered by Google App Engine
This is Rietveld 408576698