Implement <appview>

extensions/browser/api/extensions_api_client.h

Index: extensions/browser/api/extensions_api_client.h
diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h
index 88dbaa4636030e132319ff45ee7c0f1499b6f148..42383bbd5e2a82cc0b464c5ccde3857d7bd3e1c1 100644
--- a/extensions/browser/api/extensions_api_client.h
+++ b/extensions/browser/api/extensions_api_client.h
@@ -9,6 +9,7 @@
 
 #include "base/memory/ref_counted.h"
 #include "extensions/browser/api/storage/settings_namespace.h"
+#include "url/gurl.h"

[James Cook, 2014/07/11 03:16:01]

Forward declare GURL please

[Fady Samuel, 2014/07/11 15:28:56]

Done.

 
 template <class T>
 class ObserverListThreadSafe;
@@ -47,6 +48,21 @@ class ExtensionsAPIClient {
       const scoped_refptr<ObserverListThreadSafe<SettingsObserver> >& observers,
       std::map<settings_namespace::Namespace, ValueStoreCache*>* caches);
 
+  // Attaches a frame |url| inside the <appview> specified by
+  // |guest_instance_id|.

[James Cook, 2014/07/11 03:16:01]

Document the meaning of the returned boolean.

[Fady Samuel, 2014/07/11 15:28:56]

Done.

+  virtual bool AppViewInternalAttachFrame(
+      const GURL& url,

[James Cook, 2014/07/11 03:16:01]

super nit: For these sorts of Extension interfaces I've been making the
BrowserContext the first parameter, since it's often used immediately to route
the request.

[Fady Samuel, 2014/07/11 15:28:56]

Done.

+      int guest_instance_id,
+      content::BrowserContext* browser_context,
+      const std::string& guest_extension_id);
+
+  // Denies the embedding requested by the <appview> specified by
+  // |guest_instance_id|.

[James Cook, 2014/07/11 03:16:01]

Ditto document meaning of return value

[Fady Samuel, 2014/07/11 15:28:56]

Done.

+  virtual bool AppViewInternalDenyRequest(
+      int guest_instance_id,
+      content::BrowserContext* browser_context,
+      const std::string& guest_extension_id);
+
   // NOTE: If this interface gains too many methods (perhaps more than 20) it
   // should be split into one interface per API.
 };