Implement <appview>

extensions/browser/api/extensions_api_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
 #define EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
 
 #include <map>
 
 #include "base/memory/ref_counted.h"
 #include "extensions/browser/api/storage/settings_namespace.h"
+#include "url/gurl.h"

[James Cook, 2014/07/11 03:16:01]

Forward declare GURL please

[Fady Samuel, 2014/07/11 15:28:56]

Done.

 
 template <class T>
 class ObserverListThreadSafe;
 
 namespace content {
 class BrowserContext;
 }
 
 namespace extensions {
 
@@ skipping 18 matching lines @@
   // Storage API support.
 
   // Add any additional value store caches (e.g. for chrome.storage.managed)
   // to |caches|. By default adds nothing.
   virtual void AddAdditionalValueStoreCaches(
       content::BrowserContext* context,
       const scoped_refptr<SettingsStorageFactory>& factory,
       const scoped_refptr<ObserverListThreadSafe<SettingsObserver> >& observers,
       std::map<settings_namespace::Namespace, ValueStoreCache*>* caches);
 
+  // Attaches a frame |url| inside the <appview> specified by
+  // |guest_instance_id|.

[James Cook, 2014/07/11 03:16:01]

Document the meaning of the returned boolean.

[Fady Samuel, 2014/07/11 15:28:56]

Done.

+  virtual bool AppViewInternalAttachFrame(
+      const GURL& url,

[James Cook, 2014/07/11 03:16:01]

super nit: For these sorts of Extension interfaces I've been making the
BrowserContext the first parameter, since it's often used immediately to route
the request.

[Fady Samuel, 2014/07/11 15:28:56]

Done.

+      int guest_instance_id,
+      content::BrowserContext* browser_context,
+      const std::string& guest_extension_id);
+
+  // Denies the embedding requested by the <appview> specified by
+  // |guest_instance_id|.

[James Cook, 2014/07/11 03:16:01]

Ditto document meaning of return value

[Fady Samuel, 2014/07/11 15:28:56]

Done.

+  virtual bool AppViewInternalDenyRequest(
+      int guest_instance_id,
+      content::BrowserContext* browser_context,
+      const std::string& guest_extension_id);
+
   // NOTE: If this interface gains too many methods (perhaps more than 20) it
   // should be split into one interface per API.
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_