Chromium Code Reviews| Index: extensions/common/api/app_runtime.idl |
| diff --git a/extensions/common/api/app_runtime.idl b/extensions/common/api/app_runtime.idl |
| index b094c98dade73479514b0204537deb187f90b21f..6cd56d2d9f1b3044193ea18cfa6f7263e2f90c37 100644 |
| --- a/extensions/common/api/app_runtime.idl |
| +++ b/extensions/common/api/app_runtime.idl |
| @@ -42,7 +42,25 @@ namespace app.runtime { |
| boolean? isKioskSession; |
| }; |
| + // This object specifies details and operations to perform on the embedding |
| + // request. The app to be embedded can make a decision on whether or not to |
| + // allow the embedding and what to embed based on the embedder making the |
| + // request. |
| + dictionary AppEmbeddingRequest { |
| + DOMString embedderExtensionId; |
|
not at google - send to devlin
2014/07/08 22:10:46
"embedderId"? since this is chrome.app.runtime it
Fady Samuel
2014/07/09 15:15:48
Done.
|
| + |
| + // This indicates that the guest app has allowed the embedding request and |
| + // has specified a |url| within the app package to embed. |
|
not at google - send to devlin
2014/07/08 22:10:46
phrase these comments from the perspective of the
Fady Samuel
2014/07/09 15:15:48
This app decides what to embed in the embedder :-)
not at google - send to devlin
2014/07/09 15:18:11
ah right. I got my direction mixed up :)
|
| + [nocompile] static void allow(DOMString url); |
| + |
| + // This indicates that the guest app has denied the embedding request. |
|
not at google - send to devlin
2014/07/08 22:10:46
likewise
Fady Samuel
2014/07/09 15:15:48
Done.
|
| + [nocompile] static void deny(); |
| + }; |
| + |
| interface Events { |
| + // Fired when an embedding app requests to embed this app. |
| + static void onAppEmbeddingRequest(AppEmbeddingRequest request); |
|
not at google - send to devlin
2014/07/08 22:10:46
I think "onEmbedRequested" would be better:
- the
Fady Samuel
2014/07/09 15:15:48
Done.
|
| + |
| // Fired when an app is launched from the launcher. |
| static void onLaunched(optional LaunchData launchData); |