Implement <appview>

extensions/common/api/app_runtime.idl

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.app.runtime</code> API to manage the app lifecycle.
 // The app runtime manages app installation, controls the event page, and can
 // shut down the app at anytime.
 namespace app.runtime {
 
   [inline_doc] dictionary LaunchItem {
@@ skipping 24 matching lines @@
     // The referrer URL for the <code>onLaunched</code> event triggered by a
     // matching URL handler in the <code>url_handlers</code> manifest key.
     DOMString? referrerUrl;
 
     // Whether the app is being launched in a <a
     // href="https://support.google.com/chromebook/answer/3134673">Chrome OS
     // kiosk session</a>.
     boolean? isKioskSession;
   };
 
+  // This object specifies details and operations to perform on the embedding
+  // request. The app to be embedded can make a decision on whether or not to
+  // allow the embedding and what to embed based on the embedder making the
+  // request.
+  dictionary AppEmbeddingRequest {
+    DOMString embedderExtensionId;

[not at google - send to devlin, 2014/07/08 22:10:46]

"embedderId"? since this is chrome.app.runtime it feels a bit awkward using the
word "extension" in here.

[Fady Samuel, 2014/07/09 15:15:48]

Done.

+
+    // This indicates that the guest app has allowed the embedding request and
+    // has specified a |url| within the app package to embed.

[not at google - send to devlin, 2014/07/08 22:10:46]

phrase these comments from the perspective of the app that's being embedded. so,
"Allows <code>embedderId</code> to embed this app in an &lt;appview&gt; element.

|url| ^^^ I actually don't know what this means. why does the embedee pass up a
url?

[Fady Samuel, 2014/07/09 15:15:48]

This app decides what to embed in the embedder :-)

[not at google - send to devlin, 2014/07/09 15:18:11]

ah right. I got my direction mixed up :)

+    [nocompile] static void allow(DOMString url);
+
+    // This indicates that the guest app has denied the embedding request.

[not at google - send to devlin, 2014/07/08 22:10:46]

likewise

[Fady Samuel, 2014/07/09 15:15:48]

Done.

+    [nocompile] static void deny();
+  };
+
   interface Events {
+    // Fired when an embedding app requests to embed this app.
+    static void onAppEmbeddingRequest(AppEmbeddingRequest request);

[not at google - send to devlin, 2014/07/08 22:10:46]

I think "onEmbedRequested" would be better:
- the "app" is a tautology (this is on chrome.app.runtime, and besides,
extensions can embed apps too right?)
- events are phrased like "launched" not "launch(ing)", "restarted" not
"restart(ing)", so "requested" not "request".
- "embedding" just sounds awkward to me, but, I don't feel strongly about that.
maybe "embed" sounds a different kind of awkward.

[Fady Samuel, 2014/07/09 15:15:48]

Done.

+
     // Fired when an app is launched from the launcher.
     static void onLaunched(optional LaunchData launchData);
 
     // Fired at Chrome startup to apps that were running when Chrome last shut
     // down.
     static void onRestarted();
   };
 };