Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: ash/wm/toplevel_window_event_handler.cc

Issue 354343002: [M-37]: Fix dragging tab via mouse when touch is down on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/toplevel_window_event_handler.cc
diff --git a/ash/wm/toplevel_window_event_handler.cc b/ash/wm/toplevel_window_event_handler.cc
index 5d9ce4bb0d409190e5f2bd17fc637ef124d4f2c3..a759e8b76b875aa0ce5465357690d51d7ce0d83c 100644
--- a/ash/wm/toplevel_window_event_handler.cc
+++ b/ash/wm/toplevel_window_event_handler.cc
@@ -494,8 +494,11 @@ void ToplevelWindowEventHandler::HandleMouseReleased(
if (event->phase() != ui::EP_PRETARGET)
return;
- CompleteDrag(event->type() == ui::ET_MOUSE_RELEASED ?
- DRAG_COMPLETE : DRAG_REVERT);
+ if (window_resizer_) {
pkotwicz 2014/06/28 18:37:36 We should also avoid calling CompleteDrag() here i
varkha 2014/07/04 23:09:01 Should this method just return early when !window_
+ CompleteDrag(event->type() == ui::ET_MOUSE_RELEASED ?
+ DRAG_COMPLETE : DRAG_REVERT);
+ }
+
// Completing the drag may result in hiding the window. If this happens
// mark the event as handled so no other handlers/observers act upon the
// event. They should see the event on a hidden window, to determine targets
« no previous file with comments | « no previous file | ash/wm/toplevel_window_event_handler_unittest.cc » ('j') | ash/wm/toplevel_window_event_handler_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698