Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 354193002: Refactor bitmap scaler to make it easier to migrate rest of chrome to use it (Closed)

Created:
6 years, 5 months ago by humper
Modified:
6 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Refactor bitmap scaler to make it easier to migrate rest of chrome to use it Previously, the set of platform-specific function pointers to do fast convolution (e.g., neon, SSE) were passed in a structure to the scaler. I refactored this so that the scaler fills in these function pointers after it's called, so the caller doesn't have to worry about it. TBR=mtklein NOTRY=True Committed: https://skia.googlesource.com/skia/+/4f96ab36180489748f4e9bb249d773414ef0d6cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M src/core/SkBitmapProcState.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkBitmapScaler.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/core/SkBitmapScaler.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/opts/SkBitmapProcState_opts_none.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
The CQ bit was checked by humper@google.com
6 years, 5 months ago (2014-06-27 17:49:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/354193002/1
6 years, 5 months ago (2014-06-27 17:50:45 UTC) #2
humper
The CQ bit was unchecked by humper@google.com
6 years, 5 months ago (2014-06-27 18:26:43 UTC) #3
humper
The CQ bit was checked by humper@google.com
6 years, 5 months ago (2014-06-27 18:26:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/354193002/1
6 years, 5 months ago (2014-06-27 18:26:58 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 18:27:07 UTC) #6
Message was sent while issue was closed.
Change committed as 4f96ab36180489748f4e9bb249d773414ef0d6cb

Powered by Google App Engine
This is Rietveld 408576698