Issue 354143005: Fix RefPtr's move assignment operator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354143005: Fix RefPtr's move assignment operator (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
tkent, Mikhail

CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix RefPtr's move assignment operator Fix RefPtr's move assignment operator so that the moved RefPtr is always null after the assignment. Because the previous implementation was not swapping with a temporary variable, this wasn't necessary the case and this behavior is unexpected. Thanks to Mikhail Pozdnyakov for pointing this out. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177206

Patch Set 1 #

Patch Set 2 : Include <utility> #

Patch Set 3 : Stop using std::move #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
M	Source/wtf/RefPtr.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
A	Source/wtf/RefPtrTest.cpp	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
M	Source/wtf/wtf.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/354143005/40001

6 years, 5 months ago (2014-06-30 12:00:57 UTC) #5

Message was sent while issue was closed.

Change committed as 177206

Expand Messages | Collapse Messages