Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 354143005: Fix RefPtr's move assignment operator (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent, Mikhail
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Fix RefPtr's move assignment operator Fix RefPtr's move assignment operator so that the moved RefPtr is always null after the assignment. Because the previous implementation was not swapping with a temporary variable, this wasn't necessary the case and this behavior is unexpected. Thanks to Mikhail Pozdnyakov for pointing this out. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177206

Patch Set 1 #

Patch Set 2 : Include <utility> #

Patch Set 3 : Stop using std::move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M Source/wtf/RefPtr.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
A Source/wtf/RefPtrTest.cpp View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 5 months ago (2014-06-27 15:39:32 UTC) #1
Mikhail
lgtm
6 years, 5 months ago (2014-06-30 06:39:04 UTC) #2
Inactive
Thanks Mikhail :)
6 years, 5 months ago (2014-06-30 12:00:02 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-06-30 12:00:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/354143005/40001
6 years, 5 months ago (2014-06-30 12:00:57 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 12:26:35 UTC) #6
Message was sent while issue was closed.
Change committed as 177206

Powered by Google App Engine
This is Rietveld 408576698