Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: Source/wtf/RefPtrTest.cpp

Issue 354143005: Fix RefPtr's move assignment operator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Stop using std::move Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/wtf/RefPtr.h ('k') | Source/wtf/wtf.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "config.h"
6 #include "wtf/RefPtr.h"
7
8 #include "wtf/text/StringImpl.h"
9 #include <gtest/gtest.h>
10
11 namespace {
12
13 TEST(RefPtrTest, Basic)
14 {
15 RefPtr<StringImpl> string;
16 EXPECT_TRUE(!string);
17 string = StringImpl::create("test");
18 EXPECT_TRUE(!!string);
19 string.clear();
20 EXPECT_TRUE(!string);
21 }
22
23 #if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)
24 TEST(RefPtrTest, MoveAssignmentOperator)
25 {
26 RefPtr<StringImpl> a = StringImpl::create("a");
27 RefPtr<StringImpl> b = StringImpl::create("b");
28 // FIXME: Instead of explicitly casting to RefPtr<StringImpl>&& here, we sho uld use std::move, but that
29 // requires us to have a standard library that supports move semantics.
30 b = static_cast<RefPtr<StringImpl>&&>(a);
31 EXPECT_TRUE(!!b);
32 EXPECT_TRUE(!a);
33 }
34 #endif
35
36 }
OLDNEW
« no previous file with comments | « Source/wtf/RefPtr.h ('k') | Source/wtf/wtf.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698