Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 354133002: change gpudevice and pdfdevice to inherit from basedevice (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

change gpudevice and pdfdevice to inherit from basedevice BUG=skia: Committed: https://skia.googlesource.com/skia/+/89443aba5bfa2b040dc9fd24938b7d0b3decd737

Patch Set 1 #

Total comments: 10

Patch Set 2 : review comments #

Patch Set 3 : pdfdevice overrides imageInfo #

Patch Set 4 : don't call virtual inside constructor #

Patch Set 5 : undo rename in gm #

Patch Set 6 : pdfdevice needs to override newSurface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -138 lines) Patch
M include/core/SkBitmapDevice.h View 3 chunks +0 lines, -44 lines 0 comments Download
M include/core/SkDevice.h View 8 chunks +11 lines, -11 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 4 chunks +7 lines, -4 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 2 3 4 5 7 chunks +17 lines, -6 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 4 chunks +6 lines, -18 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 4 5 10 chunks +44 lines, -34 lines 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
reed1
can't wait to eliminate callers of accessBitmap() ...
6 years, 6 months ago (2014-06-27 05:03:06 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/354133002/diff/1/include/gpu/SkGpuDevice.h File include/gpu/SkGpuDevice.h (right): https://codereview.chromium.org/354133002/diff/1/include/gpu/SkGpuDevice.h#newcode26 include/gpu/SkGpuDevice.h:26: /** SkBitmapDevice -> SkBaseDevice ? https://codereview.chromium.org/354133002/diff/1/src/gpu/SkGpuDevice.cpp ...
6 years, 5 months ago (2014-06-27 12:02:58 UTC) #2
reed1
https://codereview.chromium.org/354133002/diff/1/include/gpu/SkGpuDevice.h File include/gpu/SkGpuDevice.h (right): https://codereview.chromium.org/354133002/diff/1/include/gpu/SkGpuDevice.h#newcode26 include/gpu/SkGpuDevice.h:26: /** On 2014/06/27 12:02:57, robertphillips wrote: > SkBitmapDevice -> ...
6 years, 5 months ago (2014-06-27 12:39:42 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-27 12:42:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/354133002/20001
6 years, 5 months ago (2014-06-27 12:43:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-27 13:01:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 13:18:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/484)
6 years, 5 months ago (2014-06-27 13:18:41 UTC) #8
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-27 13:57:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/354133002/40001
6 years, 5 months ago (2014-06-27 13:58:32 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-27 14:11:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 14:16:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/487)
6 years, 5 months ago (2014-06-27 14:16:43 UTC) #13
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-27 16:59:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/354133002/80001
6 years, 5 months ago (2014-06-27 17:00:24 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-27 17:15:15 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 17:30:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/492)
6 years, 5 months ago (2014-06-27 17:30:27 UTC) #18
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-27 17:40:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/354133002/100001
6 years, 5 months ago (2014-06-27 17:40:45 UTC) #20
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 18:34:24 UTC) #21
Message was sent while issue was closed. 
Change committed as 89443aba5bfa2b040dc9fd24938b7d0b3decd737

Powered by Google App Engine
This is Rietveld 408576698