Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Issue 35413009: Update swig to work correctly with Mac OS X 10.9. (Closed)

Created:
7 years, 2 months ago by Avi (use Gerrit)
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Update swig to work correctly with Mac OS X 10.9. BUG=305277 TEST=as in bug R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230490

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M swig/Lib/python/pyruntime.swg View 1 2 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
I land this, and then roll with https://codereview.chromium.org/30113003 .
7 years, 2 months ago (2013-10-23 18:57:46 UTC) #1
Nico
Link to upstream bug?
7 years, 2 months ago (2013-10-23 19:00:50 UTC) #2
Avi (use Gerrit)
On 2013/10/23 19:00:50, Nico wrote: > Link to upstream bug? in https://codereview.chromium.org/30113003/
7 years, 2 months ago (2013-10-23 19:12:22 UTC) #3
Nico
lgtm, but please include http://sourceforge.net/p/swig/bugs/1346/ in the CL description of this CL too. Thanks!
7 years, 2 months ago (2013-10-23 19:15:21 UTC) #4
Avi (use Gerrit)
Committed patchset #2 manually as r230490 (presubmit successful).
7 years, 2 months ago (2013-10-23 19:28:41 UTC) #5
Nico
On 2013/10/23 19:15:21, Nico wrote: > lgtm, but please include http://sourceforge.net/p/swig/bugs/1346/ in the CL > ...
7 years, 1 month ago (2013-10-28 15:47:25 UTC) #6
Avi (use Gerrit)
7 years, 1 month ago (2013-10-28 15:59:52 UTC) #7
Message was sent while issue was closed.
On 2013/10/28 15:47:25, Nico wrote:
> On 2013/10/23 19:15:21, Nico wrote:
> > lgtm, but please include http://sourceforge.net/p/swig/bugs/1346/ in the CL
> > description of this CL too.
> 
> ^ Looks like that got ignored? :-/

I put the bug link in the actual committed code, not the description.

Powered by Google App Engine
This is Rietveld 408576698