Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 354093004: Fix crash when using non-static CLD and update translate.gypi (Closed)

Created:
6 years, 5 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, rginda+watch_chromium.org, jam, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

This is currently a no-op, since there are no platforms that are currently shipping a non-static CLD build. However, the non-static CLD is broken and requires fixing. This change corrects a logical error that could result in SIGSEGV on some platforms after re-using an existing WebContents with a new RenderViewHost. This change also fixes an omitted dependency in translate.gypi that could result in transient build failures due to incorrect build ordering when using non-static CLD. BUG=389553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280774

Patch Set 1 #

Patch Set 2 : Gate CLD2 dependency on cld_version gyp variable #

Patch Set 3 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M chrome/browser/translate/chrome_translate_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/translate/content/browser/browser_cld_data_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/translate/content/browser/data_file_browser_cld_data_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/translate/content/browser/data_file_browser_cld_data_provider.cc View 4 chunks +27 lines, -8 lines 0 comments Download
M components/translate/content/browser/static_browser_cld_data_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andrew Hayden (chromium.org)
Takashi, cna you take a look? There's details in the linked bug... I made a ...
6 years, 5 months ago (2014-06-27 15:46:18 UTC) #1
Takashi Toyoshima
lg, but more informative description is needed for commit log as you wrote in crbug. ...
6 years, 5 months ago (2014-06-30 05:26:19 UTC) #2
Takashi Toyoshima
lgtm.
6 years, 5 months ago (2014-06-30 10:09:22 UTC) #3
andrewhayden
The CQ bit was checked by andrewhayden@google.com
6 years, 5 months ago (2014-06-30 10:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/354093004/1
6 years, 5 months ago (2014-06-30 10:13:35 UTC) #5
andrewhayden
The CQ bit was unchecked by andrewhayden@google.com
6 years, 5 months ago (2014-06-30 10:15:12 UTC) #6
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 5 months ago (2014-07-01 06:06:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/354093004/40001
6 years, 5 months ago (2014-07-01 06:07:57 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 07:26:30 UTC) #9
Message was sent while issue was closed.
Change committed as 280774

Powered by Google App Engine
This is Rietveld 408576698