components/translate/content/browser/data_file_browser_cld_data_provider.h - Issue 354093004: Fix crash when using non-static CLD and update translate.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/data_file_browser_cld_data_provider.h

Issue 354093004: Fix crash when using non-static CLD and update translate.gypi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase onto master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/content/browser/browser_cld_data_provider.h ('k') | components/translate/content/browser/data_file_browser_cld_data_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/browser/data_file_browser_cld_data_provider.h

diff --git a/components/translate/content/browser/data_file_browser_cld_data_provider.h b/components/translate/content/browser/data_file_browser_cld_data_provider.h

index fdac0531bdd19415e4b0585d8b00fbfb45251d37..9344bd7932c758060af38bcdb3177e3224d564c0 100644

--- a/components/translate/content/browser/data_file_browser_cld_data_provider.h

+++ b/components/translate/content/browser/data_file_browser_cld_data_provider.h

@@ -16,7 +16,7 @@ namespace translate {

class DataFileBrowserCldDataProvider : public BrowserCldDataProvider {

public:

- explicit DataFileBrowserCldDataProvider(content::RenderViewHost*);

+ explicit DataFileBrowserCldDataProvider(content::WebContents*);

virtual ~DataFileBrowserCldDataProvider();

// BrowserCldDataProvider implementations:

virtual bool OnMessageReceived(const IPC::Message&) OVERRIDE;

@@ -42,7 +42,7 @@ class DataFileBrowserCldDataProvider : public BrowserCldDataProvider {

const uint64);

static void OnCldDataRequestInternal();

- content::RenderViewHost* render_view_host_;

+ content::WebContents* web_contents_;

scoped_ptr<base::WeakPtrFactory<DataFileBrowserCldDataProvider> >

weak_pointer_factory_;