Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: runtime/vm/profiler.cc

Issue 354063004: Allow StackFrameIterator to be used on a different thread than the isolate whose stack frames are b… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/os_win.cc ('k') | runtime/vm/stack_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index dddfe5a3cff03a7b45bb76f62af426446129f5d1..c10b170b3197395b015471b634facb39ff1e349c 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -1665,15 +1665,15 @@ Sample* SampleBuffer::ReserveSample() {
class ProfilerDartStackWalker : public ValueObject {
public:
- explicit ProfilerDartStackWalker(Sample* sample)
+ ProfilerDartStackWalker(Isolate* isolate, Sample* sample)
: sample_(sample),
- frame_iterator_() {
+ frame_iterator_(isolate) {
ASSERT(sample_ != NULL);
}
- ProfilerDartStackWalker(Sample* sample, uword fp)
+ ProfilerDartStackWalker(Isolate* isolate, Sample* sample, uword fp)
: sample_(sample),
- frame_iterator_(fp) {
+ frame_iterator_(fp, isolate) {
ASSERT(sample_ != NULL);
}
@@ -1892,7 +1892,7 @@ void Profiler::RecordSampleInterruptCallback(
if ((isolate->stub_code() != NULL) &&
(isolate->top_exit_frame_info() != 0)) {
// Collect only Dart frames.
- ProfilerDartStackWalker stackWalker(sample);
+ ProfilerDartStackWalker stackWalker(isolate, sample);
stackWalker.walk();
} else {
// Collect native and Dart frames.
« no previous file with comments | « runtime/vm/os_win.cc ('k') | runtime/vm/stack_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698