Allow StackFrameIterator to be used on a different thread than the isolate whose stack frames are b…

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
 #include "vm/code_patcher.h"
 #include "vm/isolate.h"
@@ skipping 1647 matching lines @@
   ASSERT(samples_ != NULL);
   uintptr_t cursor = AtomicOperations::FetchAndIncrement(&cursor_);
   // Map back into sample buffer range.
   cursor = cursor % capacity_;
   return At(cursor);
 }
 
 
 class ProfilerDartStackWalker : public ValueObject {
  public:
-  explicit ProfilerDartStackWalker(Sample* sample)
+  ProfilerDartStackWalker(Isolate* isolate, Sample* sample)
       : sample_(sample),
-        frame_iterator_() {
+        frame_iterator_(isolate) {
     ASSERT(sample_ != NULL);
   }
 
-  ProfilerDartStackWalker(Sample* sample, uword fp)
+  ProfilerDartStackWalker(Isolate* isolate, Sample* sample, uword fp)
       : sample_(sample),
-        frame_iterator_(fp) {
+        frame_iterator_(fp, isolate) {
     ASSERT(sample_ != NULL);
   }
 
   int walk() {
     intptr_t frame_index = 0;
     StackFrame* frame = frame_iterator_.NextFrame();
     while (frame != NULL) {
       sample_->SetAt(frame_index, frame->pc());
       frame_index++;
       if (frame_index >= FLAG_profile_depth) {
@@ skipping 198 matching lines @@
   }
   if (FLAG_profile_vm) {
     // Collect native and Dart frames.
     ProfilerNativeStackWalker stackWalker(sample, stack_lower, stack_upper,
                                           state.pc, state.fp, state.sp);
     stackWalker.walk(isolate->heap());
   } else {
     if ((isolate->stub_code() != NULL) &&
         (isolate->top_exit_frame_info() != 0)) {
       // Collect only Dart frames.
-      ProfilerDartStackWalker stackWalker(sample);
+      ProfilerDartStackWalker stackWalker(isolate, sample);
       stackWalker.walk();
     } else {
       // Collect native and Dart frames.
       ProfilerNativeStackWalker stackWalker(sample, stack_lower, stack_upper,
                                             state.pc, state.fp, state.sp);
       stackWalker.walk(isolate->heap());
     }
   }
 }
 
 }  // namespace dart