Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 354063003: View should store a ViewTargeter instead of an EventTargeter (Closed)

Created:
6 years, 6 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

View should store a ViewTargeter instead of an EventTargeter Change |targeter_| in View to be a ViewTargeter instead of an EventTargeter. This will allow us to avoid casting when calling into ViewTargeter-specific methods in upcoming CLs. BUG=388838 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280501

Patch Set 1 #

Patch Set 2 : compilation errors #

Total comments: 2

Patch Set 3 : comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M ui/views/view.h View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M ui/views/view.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 1 5 chunks +11 lines, -7 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tdanderson
Sadrul, can you please take a look?
6 years, 6 months ago (2014-06-26 21:06:52 UTC) #1
sadrul
lgtm https://codereview.chromium.org/354063003/diff/20001/ui/views/view.h File ui/views/view.h (right): https://codereview.chromium.org/354063003/diff/20001/ui/views/view.h#newcode734 ui/views/view.h:734: ViewTargeter* GetViewTargeter() const; Just ViewTargeter* targeter() { return ...
6 years, 5 months ago (2014-06-27 21:23:38 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-06-27 22:01:05 UTC) #3
tdanderson
https://codereview.chromium.org/354063003/diff/20001/ui/views/view.h File ui/views/view.h (right): https://codereview.chromium.org/354063003/diff/20001/ui/views/view.h#newcode734 ui/views/view.h:734: ViewTargeter* GetViewTargeter() const; On 2014/06/27 21:23:38, sadrul wrote: > ...
6 years, 5 months ago (2014-06-27 22:01:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/354063003/40001
6 years, 5 months ago (2014-06-27 22:03:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-28 01:46:17 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 05:46:15 UTC) #7
Message was sent while issue was closed.
Change committed as 280501

Powered by Google App Engine
This is Rietveld 408576698