Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: ui/views/view_targeter_unittest.cc

Issue 354063003: View should store a ViewTargeter instead of an EventTargeter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment addressed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/view.cc ('k') | ui/views/widget/root_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view_targeter_unittest.cc
diff --git a/ui/views/view_targeter_unittest.cc b/ui/views/view_targeter_unittest.cc
index 8fd4ebaee7a4eb87014d8714402641f3e4f5c549..7b9b1943d229e8f2446d2872f3b86cf0808ae56e 100644
--- a/ui/views/view_targeter_unittest.cc
+++ b/ui/views/view_targeter_unittest.cc
@@ -7,6 +7,7 @@
#include "ui/events/event_targeter.h"
#include "ui/events/event_utils.h"
#include "ui/views/test/views_test_base.h"
+#include "ui/views/view_targeter.h"
#include "ui/views/widget/root_view.h"
namespace views {
@@ -61,10 +62,11 @@ TEST_F(ViewTargeterTest, ViewTargeterForKeyEvents) {
grandchild->SetFocusable(true);
grandchild->RequestFocus();
- ui::EventTargeter* targeter = new ViewTargeter();
+ ViewTargeter* view_targeter = new ViewTargeter();
+ ui::EventTargeter* targeter = view_targeter;
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
- root_view->SetEventTargeter(make_scoped_ptr(targeter));
+ root_view->SetEventTargeter(make_scoped_ptr(view_targeter));
ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, 0, true);
@@ -109,10 +111,11 @@ TEST_F(ViewTargeterTest, ViewTargeterForScrollEvents) {
content->AddChildView(child);
child->AddChildView(grandchild);
- ui::EventTargeter* targeter = new ViewTargeter();
+ ViewTargeter* view_targeter = new ViewTargeter();
+ ui::EventTargeter* targeter = view_targeter;
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
- root_view->SetEventTargeter(make_scoped_ptr(targeter));
+ root_view->SetEventTargeter(make_scoped_ptr(view_targeter));
// The event falls within the bounds of |child| and |content| but not
// |grandchild|, so |child| should be the initial target for the event.
@@ -161,7 +164,7 @@ TEST_F(ViewTargeterTest, SubtreeShouldBeExploredForEvent) {
params.bounds = gfx::Rect(0, 0, 650, 650);
widget.Init(params);
- ui::EventTargeter* targeter = new ViewTargeter();
+ ViewTargeter* targeter = new ViewTargeter();
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
root_view->SetEventTargeter(make_scoped_ptr(targeter));
@@ -226,10 +229,11 @@ TEST_F(ViewTargeterTest, CanProcessEventsWithinSubtree) {
params.bounds = gfx::Rect(0, 0, 650, 650);
widget.Init(params);
- ui::EventTargeter* targeter = new ViewTargeter();
+ ViewTargeter* view_targeter = new ViewTargeter();
+ ui::EventTargeter* targeter = view_targeter;
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
- root_view->SetEventTargeter(make_scoped_ptr(targeter));
+ root_view->SetEventTargeter(make_scoped_ptr(view_targeter));
// The coordinates used for SetBounds() are in the parent coordinate space.
TestingView v1, v2, v3;
« no previous file with comments | « ui/views/view.cc ('k') | ui/views/widget/root_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698