Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 354043005: Revert of Switch SkPDFStream's internal storage from SkStream to SkData (Closed)

Created:
6 years, 6 months ago by rmistry
Modified:
6 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkPDFStream's internal storage from SkStream to SkData (https://codereview.chromium.org/340783013/) Reason for revert: Causes canary failures Original issue's description: > Switch SkPDFStream's internal storage from SkStream to SkData > > Motivation: This makes SkPDFStream thread-safe for two threads > serializing it at once, since a SkStream has an internal position. > > Updated SkPDFFont, SkPDFGraphicState, and SkPDFPage's use of > SkPDFStream to use the SkData constructor rather than the SkStream > constructor (saving a memcpy). > > BUG=skia:2683 > > Committed: https://skia.googlesource.com/skia/+/c1dfa14b645ae274780f026dd86c9b633fbdad06 TBR=mtklein@google.com,djsollen@google.com,halcanary@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2683 Committed: https://skia.googlesource.com/skia/+/e1c55869f37bf7c5f365fddc38207dc3ec336b6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -88 lines) Patch
M gyp/pdf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 6 chunks +30 lines, -45 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M src/pdf/SkPDFPage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFStream.h View 3 chunks +8 lines, -11 lines 0 comments Download
M src/pdf/SkPDFStream.cpp View 5 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Switch SkPDFStream's internal storage from SkStream to SkData
6 years, 6 months ago (2014-06-26 21:30:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/354043005/1
6 years, 6 months ago (2014-06-26 21:30:57 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 21:31:11 UTC) #3
Message was sent while issue was closed.
Change committed as e1c55869f37bf7c5f365fddc38207dc3ec336b6c

Powered by Google App Engine
This is Rietveld 408576698