src/pdf/SkPDFPage.cpp - Issue 354043005: Revert of Switch SkPDFStream's internal storage from SkStream to SkData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFPage.cpp

Issue 354043005: Revert of Switch SkPDFStream's internal storage from SkStream to SkData (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/pdf/SkPDFPage.cpp

diff --git a/src/pdf/SkPDFPage.cpp b/src/pdf/SkPDFPage.cpp

index cfb6790876f1bba7ce5839c78e2353e6bf890aa7..8961d2f3d3ea4f963d8825252c096079921706e2 100644

--- a/src/pdf/SkPDFPage.cpp

+++ b/src/pdf/SkPDFPage.cpp

@@ -7,11 +7,11 @@

-#include "SkData.h"

#include "SkPDFCatalog.h"

#include "SkPDFDevice.h"

#include "SkPDFPage.h"

#include "SkPDFResourceDict.h"

+#include "SkStream.h"

SkPDFPage::SkPDFPage(SkPDFDevice* content)

: SkPDFDict("Page"),

@@ -36,7 +36,7 @@

}

- SkAutoTUnref<SkData> content(fDevice->copyContentToData());

+ SkAutoTUnref<SkStream> content(fDevice->content());

fContentStream.reset(new SkPDFStream(content.get()));

insert("Contents", new SkPDFObjRef(fContentStream.get()))->unref();

}

« no previous file with comments | « src/pdf/SkPDFImage.cpp ('k') | src/pdf/SkPDFStream.h » ('j') | no next file with comments »