net/socket/ssl_client_socket_nss.h - Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.h

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implemented better memory management and callback handling. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_nss.h

diff --git a/net/socket/ssl_client_socket_nss.h b/net/socket/ssl_client_socket_nss.h

index e8cce574b6407ffb0e6816a9668f1ac333944994..c5f7e9a17ef655e9a2bc84f16287a3d3880b58da 100644

--- a/net/socket/ssl_client_socket_nss.h

+++ b/net/socket/ssl_client_socket_nss.h

@@ -68,6 +68,13 @@ class SSLClientSocketNSS : public SSLClientSocket {

virtual ~SSLClientSocketNSS();

// SSLClientSocket implementation.

+ virtual bool InSessionCache() const OVERRIDE;

+ virtual void SetHandshakeSuccessCallback(

+ const base::Closure& callback) OVERRIDE;

+ virtual void SetHandshakeFailureCallback(

+ const base::Closure& callback) OVERRIDE;

+ virtual void SetIsLeader() OVERRIDE;

+ virtual void OnSocketFailure() OVERRIDE;

wtc 2014/07/15 19:27:58 Delete these two methods.

mshelley 2014/07/17 00:28:44 Done.

virtual void GetSSLCertRequestInfo(

SSLCertRequestInfo* cert_request_info) OVERRIDE;

virtual NextProtoStatus GetNextProto(std::string* proto,

« net/socket/ssl_client_socket.h ('K') | « net/socket/ssl_client_socket.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | net/socket/ssl_client_socket_nss.cc » ('J')