Implements new, more robust design for communicating between SSLConnectJobs.

net/socket/ssl_client_socket_nss.cc

Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 3a8b39e678c2785ea4d6fd7c60fea762fb599883..89f8ecbf8c66b2aac0032c639d8b4c3448827612 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2881,6 +2881,29 @@ bool SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
   return true;
 }
 
+bool SSLClientSocketNSS::InSessionCache() const {
+  // For now, always return true so that SSLConnectJobs are never held back.
+  return true;
+}
+
+void SSLClientSocketNSS::SetHandshakeSuccessCallback(
+    const base::Closure& callback) {
+  NOTREACHED();
+}
+
+void SSLClientSocketNSS::SetHandshakeFailureCallback(
+    const base::Closure& callback) {
+  NOTREACHED();
+}
+
+void SSLClientSocketNSS::SetIsLeader() {
+  NOTREACHED();
+}
+
+void SSLClientSocketNSS::OnSocketFailure() {
+  NOTREACHED();

[Ryan Sleevi, 2014/07/12 00:12:15]

Is NOTREACHED() correct? It seems like it should be NOT_IMPLEMENTED() instead

the default not implemented policy is to LOG(ERROR) at runtime, whereas
NOTREACHED() will DCHECK(false) in debug builds (crashing the test)

[mshelley, 2014/07/17 00:28:44]

Done.

+}
+
 void SSLClientSocketNSS::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   EnterFunction("");