Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 353623003: Remove obsolete document wrapper creation in named constructors (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-document-cleanup
Project:
blink
Visibility:
Public.

Description

Remove obsolete document wrapper creation in named constructors For historical reasons, named constructor callbacks contained the code toV8(document, info.Holder(), isolate); to ensure a document wrapper was created. This was necessary to ensure the asynchronous lifetime of HTMLAudioElement and HTMLImageElement. This is no longer the case, so drop the extra code. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -35 lines) Patch
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Jens Widell
Clean-up as explained in https://codereview.chromium.org/340763003/#msg13. With some additional minor changes, the template code for regular ...
6 years, 6 months ago (2014-06-24 08:24:04 UTC) #1
haraken
LGTM. > Clean-up as explained in https://codereview.chromium.org/340763003/#msg13. > > With some additional minor changes, the ...
6 years, 6 months ago (2014-06-24 08:32:00 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-24 08:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/353623003/1
6 years, 6 months ago (2014-06-24 08:40:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 09:41:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 10:21:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21252)
6 years, 6 months ago (2014-06-24 10:21:37 UTC) #7
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-24 12:31:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/353623003/1
6 years, 6 months ago (2014-06-24 12:31:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 13:10:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 13:54:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21381)
6 years, 6 months ago (2014-06-24 13:54:11 UTC) #12
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-24 18:12:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/353623003/1
6 years, 6 months ago (2014-06-24 18:12:19 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 19:20:07 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 19:44:12 UTC) #16
Message was sent while issue was closed.
Change committed as 176868

Powered by Google App Engine
This is Rietveld 408576698