Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

Issue 353623003: Remove obsolete document wrapper creation in named constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-document-cleanup
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestInterfaceNamedConstructor2.h" 8 #include "V8TestInterfaceNamedConstructor2.h"
9 9
10 #include "bindings/v8/ExceptionState.h" 10 #include "bindings/v8/ExceptionState.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 if (!info.IsConstructCall()) { 53 if (!info.IsConstructCall()) {
54 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Audi o"), isolate); 54 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Audi o"), isolate);
55 return; 55 return;
56 } 56 }
57 57
58 if (ConstructorMode::current(isolate) == ConstructorMode::WrapExistingObject ) { 58 if (ConstructorMode::current(isolate) == ConstructorMode::WrapExistingObject ) {
59 v8SetReturnValue(info, info.Holder()); 59 v8SetReturnValue(info, info.Holder());
60 return; 60 return;
61 } 61 }
62 62
63 Document* documentPtr = currentDOMWindow(isolate)->document(); 63 Document& document = *toDocument(currentExecutionContext(isolate));
64 ASSERT(documentPtr);
65 Document& document = *documentPtr;
66
67 // Make sure the document is added to the DOM Node map. Otherwise, the TestI nterfaceNamedConstructor2 instance
68 // may end up being the only node in the map and get garbage-collected prema turely.
69 toV8(documentPtr, info.Holder(), isolate);
70 64
71 if (UNLIKELY(info.Length() < 1)) { 65 if (UNLIKELY(info.Length() < 1)) {
72 throwMinimumArityTypeErrorForConstructor("TestInterfaceNamedConstructor2 ", 1, info.Length(), info.GetIsolate()); 66 throwMinimumArityTypeErrorForConstructor("TestInterfaceNamedConstructor2 ", 1, info.Length(), info.GetIsolate());
73 return; 67 return;
74 } 68 }
75 V8StringResource<> stringArg; 69 V8StringResource<> stringArg;
76 { 70 {
77 TOSTRING_VOID_INTERNAL(stringArg, info[0]); 71 TOSTRING_VOID_INTERNAL(stringArg, info[0]);
78 } 72 }
79 RefPtr<TestInterfaceNamedConstructor2> impl = TestInterfaceNamedConstructor2 ::createForJSConstructor(stringArg); 73 RefPtr<TestInterfaceNamedConstructor2> impl = TestInterfaceNamedConstructor2 ::createForJSConstructor(stringArg);
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 fromInternalPointer(object)->deref(); 164 fromInternalPointer(object)->deref();
171 } 165 }
172 166
173 template<> 167 template<>
174 v8::Handle<v8::Value> toV8NoInline(TestInterfaceNamedConstructor2* impl, v8::Han dle<v8::Object> creationContext, v8::Isolate* isolate) 168 v8::Handle<v8::Value> toV8NoInline(TestInterfaceNamedConstructor2* impl, v8::Han dle<v8::Object> creationContext, v8::Isolate* isolate)
175 { 169 {
176 return toV8(impl, creationContext, isolate); 170 return toV8(impl, creationContext, isolate);
177 } 171 }
178 172
179 } // namespace WebCore 173 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698