[Android] Switch to Gin Java Bridge implementation

[Android] Switch to Gin Java Bridge implementation

What this patch does:

 -- plumbs in GinJavaBridge... instead of JavaBridge... classes on
    browser and renderer sides;

 -- fixes the issue with adding JavaScript interfaces to popup windows
    created via WebChromeClient.onCreatePopup;

 -- updates JavaBridge tests to match the behaviour of the new
    implementation.

BUG=355644
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282004

[mnaganov (inactive), 2014-06-27 17:10:04]

The patch we all have been waiting for :)

I'm not yet removing files from the old implementation to simplify reverting, if
needed (hopefully not).

jam@: I'm allowing GinJavaBridgeDispatcherHost to include "web_contents.h", as
GinJavaBridgeDispatcherHost is a WebContentsObserver anyway (the same as for the
old JavaBridgeDispatcherHostManager), and it's not a part of RVH implementation.
Just wanted to make sure it's OK.

[benm (inactive), 2014-06-30 12:14:57]

lgtm

woot!

[mnaganov (inactive), 2014-06-30 12:39:42]

Thanks, Ben!

Adding OWNERS:

jamesr@: PTAL at content/renderer/
yaron@: PTAL at content/public/android/

[jam, 2014-06-30 16:18:27]

On 2014/06/27 17:10:04, Mikhail Naganov (Cr) wrote:
> The patch we all have been waiting for :)
> 
> I'm not yet removing files from the old implementation to simplify reverting,
if
> needed (hopefully not).
> 
> jam@: I'm allowing GinJavaBridgeDispatcherHost to include "web_contents.h", as
> GinJavaBridgeDispatcherHost is a WebContentsObserver anyway (the same as for
the
> old JavaBridgeDispatcherHostManager), and it's not a part of RVH
implementation.
> Just wanted to make sure it's OK.

this code is in the wrong location then, hence the need for this DEPS exception.
it's not used by any code in content\browser\renderer_host. Searching for
"content/browser/renderer_host/java/" -file:content/browser/renderer_host/java/ 
shows only content/browser/android/ includes. so this code should just move to
content/browser/android/java

[mnaganov (inactive), 2014-06-30 16:52:15]

On 2014/06/30 16:18:27, jam wrote:
> On 2014/06/27 17:10:04, Mikhail Naganov (Cr) wrote:
> > The patch we all have been waiting for :)
> > 
> > I'm not yet removing files from the old implementation to simplify
reverting,
> if
> > needed (hopefully not).
> > 
> > jam@: I'm allowing GinJavaBridgeDispatcherHost to include "web_contents.h",
as
> > GinJavaBridgeDispatcherHost is a WebContentsObserver anyway (the same as for
> the
> > old JavaBridgeDispatcherHostManager), and it's not a part of RVH
> implementation.
> > Just wanted to make sure it's OK.
> 
> this code is in the wrong location then, hence the need for this DEPS
exception.
> it's not used by any code in content\browser\renderer_host. Searching for
> "content/browser/renderer_host/java/"
-file:content/browser/renderer_host/java/ 
> shows only content/browser/android/ includes. so this code should just move to
> content/browser/android/java

Great idea! Moving: https://codereview.chromium.org/336313018/

[jamesr, 2014-06-30 19:17:52]

This is exciting.  Guessing that the move needs to happen first?

https://codereview.chromium.org/353163002/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/353163002/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:62: #include
"content/renderer/java/gin_java_bridge_dispatcher.h"
why isn't this in the OS_ANDROID block?

[mnaganov (inactive), 2014-07-01 12:38:10]

OK, no more changes to DEPS after I have moved the source code files. Thank you,
John!

https://codereview.chromium.org/353163002/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/353163002/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:62: #include
"content/renderer/java/gin_java_bridge_dispatcher.h"
On 2014/06/30 19:17:52, jamesr wrote:
> why isn't this in the OS_ANDROID block?

Done.

[jamesr, 2014-07-01 15:13:43]

lgtm

[mnaganov (inactive), 2014-07-01 15:38:38]

Thanks, James!

yaron@: PTAL at content/browser/android/content_view_core.* changes (apologies
for wrong attribution in my initial request).

[mnaganov (inactive), 2014-07-08 08:36:08]

yaron@: Ping!

[Yaron, 2014-07-08 16:43:21]

lgtm

sorry this didn't make it priority inbox for some reason so I missed it :(

[mnaganov (inactive), 2014-07-08 17:03:23]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-07-08 17:04:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mnaganov@chromium.org/353163002/40001

[commit-bot: I haz the power, 2014-07-08 19:04:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-07-08 19:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 19:23:55]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[mnaganov (inactive), 2014-07-09 08:42:59]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-07-09 08:44:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mnaganov@chromium.org/353163002/60001

[commit-bot: I haz the power, 2014-07-09 11:07:52]

Change committed as 282004