content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java - Issue 353163002: [Android] Switch to Gin Java Bridge implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

Issue 353163002: [Android] Switch to Gin Java Bridge implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed AwSettingsTest#testBlockNetworkLoadsWithAudio Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

index c344416500f085d9825270f7e1af5768c37c290a..472b253d547142a38af69ca85b6e301793ce4a50 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

@@ -172,9 +172,8 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {

executeJavaScript("testObject.setByteValue(" + Byte.MAX_VALUE + " + 42);");

assertEquals(Byte.MIN_VALUE + 42 - 1, mTestObject.waitForByteValue());

- // LIVECONNECT_COMPLIANCE: Should convert to numeric char value.

executeJavaScript("testObject.setCharValue(42);");

- assertEquals('\u0000', mTestObject.waitForCharValue());

+ assertEquals(42, mTestObject.waitForCharValue());

executeJavaScript("testObject.setShortValue(42);");

assertEquals(42, mTestObject.waitForShortValue());