Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 353063007: Revert of [DBus] Explicitly instantiate dbus::Property variants (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [DBus] Explicitly instantiate dbus::Property variants (https://codereview.chromium.org/354553002/) Reason for revert: This causes link error: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/48613/steps/compile/logs/stdio Original issue's description: > [DBus] Explicitly instantiate dbus::Property variants > > dbus::Property<std::vector<uint8> > isn't instantiated in libdbus in non-ChromeOS build + latest clang. > That causes instantiation of the template in dbus_unittests, and causes link failure. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280264 TBR=keybuk@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M dbus/property.h View 2 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tzik
Created Revert of [DBus] Explicitly instantiate dbus::Property variants
6 years, 6 months ago (2014-06-27 08:08:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/353063007/1
6 years, 6 months ago (2014-06-27 08:09:42 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 08:10:48 UTC) #3
Message was sent while issue was closed.
Change committed as 280267

Powered by Google App Engine
This is Rietveld 408576698