Issue 352983004: DevTools: add more jsdocs to NetworkPanel. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(58)

My Issues | Starred Open | Closed | All

Issue 352983004: DevTools: add more jsdocs to NetworkPanel. (Closed)

Created:
6 years, 5 months ago by eustas

Modified:
6 years, 5 months ago

Reviewers:
apavlov, vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: add more jsdocs to NetworkPanel. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177075

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -24 lines)			Patch
	M	Source/devtools/front_end/components/ObjectPopoverHelper.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/devtools/front_end/elements/ElementsPanel.js	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
	M	Source/devtools/front_end/network/NetworkPanel.js	View	1	29 chunks	+130 lines, -9 lines	0 comments	Download
	M	Source/devtools/front_end/profiler/CanvasProfileView.js	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
	M	Source/devtools/front_end/sources/JavaScriptSourceFrame.js	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TimelineView.js	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
	M	Source/devtools/front_end/ui/Popover.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 15 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/352983004/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/352983004/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode471 Source/devtools/front_end/elements/ElementsPanel.js:471: _getPopoverAnchor: function(element) Please annotate this method. https://codereview.chromium.org/352983004/diff/1/Source/devtools/front_end/profiler/CanvasProfileView.js File ...

6 years, 5 months ago (2014-06-26 13:55:35 UTC) #2

eustas

https://codereview.chromium.org/352983004/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/352983004/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode471 Source/devtools/front_end/elements/ElementsPanel.js:471: _getPopoverAnchor: function(element) On 2014/06/26 13:55:35, vsevik wrote: > Please ...

6 years, 5 months ago (2014-06-26 14:15:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/352983004/20001

6 years, 5 months ago (2014-06-26 14:18:24 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...

6 years, 5 months ago (2014-06-26 15:19:52 UTC) #6

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 5 months ago (2014-06-27 05:25:26 UTC) #7

commit-bot: I haz the power

Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/10746)

6 years, 5 months ago (2014-06-27 05:25:27 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/352983004/20001

6 years, 5 months ago (2014-06-27 05:35:30 UTC) #10

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 5 months ago (2014-06-27 05:35:39 UTC) #11

commit-bot: I haz the power

Failed to apply patch for Source/devtools/front_end/sources/JavaScriptSourceFrame.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

6 years, 5 months ago (2014-06-27 05:35:40 UTC) #12

Failed to apply patch for
Source/devtools/front_end/sources/JavaScriptSourceFrame.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/sources/JavaScriptSourceFrame.js
  Hunk #1 FAILED at 423.
  Hunk #2 succeeded at 450 (offset 1 line).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/devtools/front_end/sources/JavaScriptSourceFrame.js.rej

Patch:       Source/devtools/front_end/sources/JavaScriptSourceFrame.js
Index: Source/devtools/front_end/sources/JavaScriptSourceFrame.js
diff --git a/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
b/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
index
f2331b8913c89994b9ae2f855f63f3babf659da0..9c6b326d0cd06568f95b61dd71a8f1eb8301d167
100644
--- a/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
+++ b/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
@@ -423,17 +423,17 @@ WebInspector.JavaScriptSourceFrame.prototype = {
     _getPopoverAnchor: function(element, event)
     {
         if (!WebInspector.debuggerModel.isPaused())
-            return null;
+            return;
 
         var textPosition = this.textEditor.coordinatesToCursorPosition(event.x,
event.y);
         if (!textPosition)
-            return null;
+            return;
         var mouseLine = textPosition.startLine;
         var mouseColumn = textPosition.startColumn;
         var textSelection = this.textEditor.selection().normalize();
         if (textSelection && !textSelection.isEmpty()) {
             if (textSelection.startLine !== textSelection.endLine ||
textSelection.startLine !== mouseLine || mouseColumn < textSelection.startColumn
|| mouseColumn > textSelection.endColumn)
-                return null;
+                return;
 
             var leftCorner =
this.textEditor.cursorPositionToCoordinates(textSelection.startLine,
textSelection.startColumn);
             var rightCorner =
this.textEditor.cursorPositionToCoordinates(textSelection.endLine,
textSelection.endColumn);
@@ -449,14 +449,14 @@ WebInspector.JavaScriptSourceFrame.prototype = {
 
         var token = this.textEditor.tokenAtTextPosition(textPosition.startLine,
textPosition.startColumn);
         if (!token)
-            return null;
+            return;
         var lineNumber = textPosition.startLine;
         var line = this.textEditor.line(lineNumber);
         var tokenContent = line.substring(token.startColumn, token.endColumn +
1);
 
         var isIdentifier = token.type.startsWith("js-variable") ||
token.type.startsWith("js-property") || token.type == "js-def";
         if (!isIdentifier && (token.type !== "js-keyword" || tokenContent !==
"this"))
-            return null;
+            return;
 
         var leftCorner =
this.textEditor.cursorPositionToCoordinates(lineNumber, token.startColumn);
         var rightCorner =
this.textEditor.cursorPositionToCoordinates(lineNumber, token.endColumn + 1);

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/352983004/40001

6 years, 5 months ago (2014-06-27 05:45:31 UTC) #14

Message was sent while issue was closed.

Change committed as 177075

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698