Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: Source/devtools/front_end/elements/ElementsPanel.js

Issue 352983004: DevTools: add more jsdocs to NetworkPanel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/Source/devtools/front_end/elements/ElementsPanel.js b/Source/devtools/front_end/elements/ElementsPanel.js
index 025686a9233d35f10d73179ef94bb228834095d6..95535599bc02065d0c414d0317681e0fcd16dd80 100644
--- a/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/Source/devtools/front_end/elements/ElementsPanel.js
@@ -468,15 +468,20 @@ WebInspector.ElementsPanel.prototype = {
pane.populateNodeContextMenu(node, contextMenu);
},
- _getPopoverAnchor: function(element)
+ /**
+ * @param {!Element} element
+ * @param {!Event} event
+ * @return {!Element|!AnchorBox|undefined}
+ */
+ _getPopoverAnchor: function(element, event)
{
var anchor = element.enclosingNodeOrSelfWithClass("webkit-html-resource-link");
if (!anchor || !anchor.href)
- return null;
+ return;
var treeOutlineElement = anchor.enclosingNodeOrSelfWithClass("elements-tree-outline");
if (!treeOutlineElement)
- return null;
+ return;
for (var i = 0; i < this._treeOutlines.length; ++i) {
if (this._treeOutlines[i].element !== treeOutlineElement)
@@ -484,11 +489,10 @@ WebInspector.ElementsPanel.prototype = {
var resource = this._treeOutlines[i].target().resourceTreeModel.resourceForURL(anchor.href);
if (!resource || resource.type !== WebInspector.resourceTypes.Image)
- return null;
+ return;
anchor.removeAttribute("title");
return anchor;
}
- return null;
},
/**
« no previous file with comments | « Source/devtools/front_end/components/ObjectPopoverHelper.js ('k') | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698