Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 352793004: Fix use-of-uninitialized-value in TransformationMatrix::blend() (Closed)

Created:
6 years, 5 months ago by alancutter (OOO until 2018)
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix use-of-uninitialized-value in TransformationMatrix::blend() TransformationMatrix::blend() was attempting to blend between non-invertable matricies. This resulted in garbage stack variables being used. This patch ensures that blend() will fall back to a 50% step interpolation when one of the sides are not invertable. BUG=389316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/transforms/TransformationMatrix.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
A Source/platform/transforms/TransformationMatrixTest.cpp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
alancutter (OOO until 2018)
6 years, 5 months ago (2014-06-27 05:49:02 UTC) #1
alancutter (OOO until 2018)
Oops, timloh is not an OWNER here. +leviw: Are you able to review this fix?
6 years, 5 months ago (2014-06-27 09:40:53 UTC) #2
alancutter (OOO until 2018)
leviw: Poke.
6 years, 5 months ago (2014-07-02 10:50:33 UTC) #3
leviw_travelin_and_unemployed
Totally. LGTM.
6 years, 5 months ago (2014-07-02 17:48:41 UTC) #4
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 5 months ago (2014-07-03 00:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/352793004/1
6 years, 5 months ago (2014-07-03 00:08:57 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-03 01:19:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 02:07:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28826)
6 years, 5 months ago (2014-07-03 02:07:21 UTC) #9
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 5 months ago (2014-07-03 02:57:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/352793004/1
6 years, 5 months ago (2014-07-03 02:57:50 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 06:50:26 UTC) #12
Message was sent while issue was closed.
Change committed as 177453

Powered by Google App Engine
This is Rietveld 408576698