Source/platform/transforms/TransformationMatrix.cpp - Issue 352793004: Fix use-of-uninitialized-value in TransformationMatrix::blend()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/transforms/TransformationMatrix.cpp

Issue 352793004: Fix use-of-uninitialized-value in TransformationMatrix::blend() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/transforms/TransformationMatrix.cpp

diff --git a/Source/platform/transforms/TransformationMatrix.cpp b/Source/platform/transforms/TransformationMatrix.cpp

index 4403d3e7ec91180ff8865f15023b1a11d25ce89b..172d0bf4a96dd446b977526b8fdf537aee7eaa21 100644

--- a/Source/platform/transforms/TransformationMatrix.cpp

+++ b/Source/platform/transforms/TransformationMatrix.cpp

@@ -1364,8 +1364,11 @@ void TransformationMatrix::blend(const TransformationMatrix& from, double progre

// decompose

DecomposedType fromDecomp;

DecomposedType toDecomp;

- from.decompose(fromDecomp);

- decompose(toDecomp);

+ if (!from.decompose(fromDecomp) || !decompose(toDecomp)) {

+ if (progress < 0.5)

+ *this = from;

+ return;

+ }

// interpolate

blendFloat(fromDecomp.scaleX, toDecomp.scaleX, progress);