Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup-typechecking
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
index 8fcd01266b440865c8bfd8b34e5163d648300f9c..c00620fd7b6dc06928639bbd7aa6448736a98858 100644
--- a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
@@ -179,9 +179,8 @@ static void initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttri
{
v8::Handle<v8::Object> holder = info.Holder();
TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
- bool isNull = false;
- RefPtr<TestInterfaceEmpty> cppValue(impl->initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute(isNull));
- if (isNull) {
+ RefPtr<TestInterfaceEmpty> cppValue(impl->initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute());
+ if (!cppValue) {
v8SetReturnValueNull(info);
return;
}
« no previous file with comments | « Source/bindings/tests/idls/TestSpecialOperations.idl ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698