Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 352523003: Have the Debugger extension api check that it has access to the tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PermissionsData::UrlIsRestricted() Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index a23fb2b56d173897cf5f71858cbbdde8b887d6e3..68e5ce5563d73909bf97f0f8a97ad275304ea223 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -68,6 +68,14 @@ class PermissionsData {
// whitelist of extensions that can script all pages.
static bool CanExecuteScriptEverywhere(const Extension* extension);
+ // Returns true if the given |url| is restricted for the given |extension|,
+ // as is commonly the case for chrome:// urls.
+ // NOTE: You probably want to use CanAccessPage().
+ static bool UrlIsRestricted(const GURL& document_url,
not at google - send to devlin 2014/06/25 20:42:17 please call this IsRestrictedURL, or IsRestrictedU
Devlin 2014/06/25 23:30:00 Done.
+ const GURL& top_frame_url,
+ const Extension* extension,
+ std::string* error);
not at google - send to devlin 2014/06/25 20:42:17 it would also be nice to test this function (compl
Devlin 2014/06/25 23:30:00 Done.
+
// Sets the runtime permissions of the given |extension| to |permissions|.
void SetActivePermissions(const PermissionSet* active) const;

Powered by Google App Engine
This is Rietveld 408576698