chrome/test/data/extensions/api_test/debugger/background.js - Issue 352523003: Have the Debugger extension api check that it has access to the tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/debugger/background.js

Issue 352523003: Have the Debugger extension api check that it has access to the tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add PermissionsData::UrlIsRestricted() Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/debugger/debugger_api.cc ('K') | « chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc ('k') | extensions/common/permissions/permissions_data.h » ('j') | extensions/common/permissions/permissions_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/debugger/background.js

diff --git a/chrome/test/data/extensions/api_test/debugger/background.js b/chrome/test/data/extensions/api_test/debugger/background.js

index a6e2e8d960f41d33ec1e4fdc147b6de0b6107366..b902f8678303dd0a6d95b274e6288261993c197c 100644

--- a/chrome/test/data/extensions/api_test/debugger/background.js

+++ b/chrome/test/data/extensions/api_test/debugger/background.js

@@ -108,7 +108,7 @@ chrome.test.runTests([

chrome.tabs.create({url:"chrome://version"}, function(tab) {

var debuggee = {tabId: tab.id};

chrome.debugger.attach(debuggee, protocolVersion,

- fail("Can not attach to the page with the \"chrome://\" scheme."));

+ fail("Cannot access a chrome:// URL"));

chrome.tabs.remove(tab.id);

});