Be explicit about target type in platform_util::OpenItem()

chrome/browser/platform_util.h

Index: chrome/browser/platform_util.h
diff --git a/chrome/browser/platform_util.h b/chrome/browser/platform_util.h
index 916f3a307c78cb99af4dae2f82191483985a8475..9e5d0175e560da9ba1cfe23414f8929eabbfd05e 100644
--- a/chrome/browser/platform_util.h
+++ b/chrome/browser/platform_util.h
@@ -25,9 +25,15 @@ namespace platform_util {
 // Must be called from the UI thread.
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path);
 
-// Open the given file in the desktop's default manner.
-// Must be called from the UI thread.
-void OpenItem(Profile* profile, const base::FilePath& full_path);
+// Open the given file in the desktop's default manner. |full_path| must point

[James Hawkins, 2014/09/25 17:47:26]

Unfortunately it's not consistent with the rest of this file, but these should
be "Opens".

[asanka, 2014/09/25 22:24:20]

Done. Changed to "Opens". Also reworded a bit.

+// to an existing file. If the files doesn't exist or is a directory, then no
+// action will be taken. Must be called from the UI thread.
+void OpenFile(Profile* profile, const base::FilePath& full_path);
+
+// Open the given folder in the file manager. If |full_path| does not exist or
+// is not a directory, the nno action will be taken. Must be called from the UI

[James Hawkins, 2014/09/25 17:47:26]

"then no"

[asanka, 2014/09/25 22:24:20]

Done. Need spell checker for comments.

+// thread.
+void OpenFolder(Profile* profile, const base::FilePath& full_path);

[hashimoto, 2014/09/25 02:34:05]

Please use one of "directory" and "folder", not both of them.
I think "directory" is a better word because it seems used more widely.

[asanka, 2014/09/25 22:24:20]

'Folder' is consistent with the ShowItemInFolder function above and the use of
folder vs. directory in general parlance. See for example:
http://superuser.com/questions/187900/what-is-the-difference-between-a-direct...
. While the target is represented by a FilePath, the actual object that will be
opened is not required to be the file system directory named by |full_path|.

You are right that I refer to a 'directory' occasionally in the comments. I've
fixed the instances that I found.

 
 // Open the given external protocol URL in the desktop's default manner.
 // (For example, mailto: URLs in the default mail user agent.)