Be explicit about target type in platform_util::OpenItem()

chrome/browser/platform_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PLATFORM_UTIL_H_
 #define CHROME_BROWSER_PLATFORM_UTIL_H_
 
 #include <string>
 
 #include "base/strings/string16.h"
 #include "ui/gfx/native_widget_types.h"
 
 class GURL;
 class Profile;
 
 namespace base {
 class FilePath;
 }
 
 namespace platform_util {
 
 // Show the given file in a file manager. If possible, select the file.
 // The |profile| is used to determine the running profile of file manager app
 // in Chrome OS only. Not used in other platforms.
 // Must be called from the UI thread.
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path);
 
-// Open the given file in the desktop's default manner.
-// Must be called from the UI thread.
-void OpenItem(Profile* profile, const base::FilePath& full_path);
+// Open the given file in the desktop's default manner. |full_path| must point

[James Hawkins, 2014/09/25 17:47:26]

Unfortunately it's not consistent with the rest of this file, but these should
be "Opens".

[asanka, 2014/09/25 22:24:20]

Done. Changed to "Opens". Also reworded a bit.

+// to an existing file. If the files doesn't exist or is a directory, then no
+// action will be taken. Must be called from the UI thread.
+void OpenFile(Profile* profile, const base::FilePath& full_path);
+
+// Open the given folder in the file manager. If |full_path| does not exist or
+// is not a directory, the nno action will be taken. Must be called from the UI

[James Hawkins, 2014/09/25 17:47:26]

"then no"

[asanka, 2014/09/25 22:24:20]

Done. Need spell checker for comments.

+// thread.
+void OpenFolder(Profile* profile, const base::FilePath& full_path);

[hashimoto, 2014/09/25 02:34:05]

Please use one of "directory" and "folder", not both of them.
I think "directory" is a better word because it seems used more widely.

[asanka, 2014/09/25 22:24:20]

'Folder' is consistent with the ShowItemInFolder function above and the use of
folder vs. directory in general parlance. See for example:
http://superuser.com/questions/187900/what-is-the-difference-between-a-direct...
. While the target is represented by a FilePath, the actual object that will be
opened is not required to be the file system directory named by |full_path|.

You are right that I refer to a 'directory' occasionally in the comments. I've
fixed the instances that I found.

 
 // Open the given external protocol URL in the desktop's default manner.
 // (For example, mailto: URLs in the default mail user agent.)
 // Must be called from the UI thread.
 void OpenExternal(Profile* profile, const GURL& url);
 
 // Get the top level window for the native view. This can return NULL.
 gfx::NativeWindow GetTopLevel(gfx::NativeView view);
 
 // Get the direct parent of |view|, may return NULL.
@@ skipping 13 matching lines @@
 #if defined(OS_MACOSX)
 // On 10.7+, back and forward swipe gestures can be triggered using a scroll
 // gesture, if enabled in System Preferences. This function returns true if
 // the feature is supported and enabled, and false otherwise.
 bool IsSwipeTrackingFromScrollEventsEnabled();
 #endif
 
 }  // namespace platform_util
 
 #endif  // CHROME_BROWSER_PLATFORM_UTIL_H_