Update survival statistics correctly in the Scavenger.

Update survival statistics correctly in the Scavenger.

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21991

[Igor Sheludko, 2014-06-24 14:51:00]

lgtm

[Igor Sheludko, 2014-06-24 15:12:38]

https://codereview.chromium.org/351893003/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/351893003/diff/1/src/heap.cc#newcode2028
src/heap.cc:2028:
heap->promotion_queue()->SetNewLimit(heap->new_space()->top());
Shouldn't limit updating be done only if the allocation succeeded?

It would be really great to merge both ShouldBePromoted() and else cases.

[Hannes Payer (out of office), 2014-06-24 16:28:15]

https://codereview.chromium.org/351893003/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/351893003/diff/1/src/heap.cc#newcode2028
src/heap.cc:2028:
heap->promotion_queue()->SetNewLimit(heap->new_space()->top());
On 2014/06/24 15:12:38, Igor Sheludko wrote:
> Shouldn't limit updating be done only if the allocation succeeded?
> 
> It would be really great to merge both ShouldBePromoted() and else cases.

I changed the order, WDYT?

[Igor Sheludko, 2014-06-24 16:45:52]

I think it's much better now. lgtm with nits:

https://codereview.chromium.org/351893003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/351893003/diff/20001/src/heap.cc#newcode1988
src/heap.cc:1988: AllocationResult allocation;
Move this closer to the usages.

https://codereview.chromium.org/351893003/diff/20001/src/heap.cc#newcode1998
src/heap.cc:1998: if (!allocation.IsRetry()) {
To be uniform:
  HeapObject* target = NULL;
  if (allocation.To(&target)) {

[Hannes Payer (out of office), 2014-06-24 19:23:04]

https://codereview.chromium.org/351893003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/351893003/diff/20001/src/heap.cc#newcode1988
src/heap.cc:1988: AllocationResult allocation;
On 2014/06/24 16:45:51, Igor Sheludko wrote:
> Move this closer to the usages.

Done. I removed the local version and use just one global instance.

https://codereview.chromium.org/351893003/diff/20001/src/heap.cc#newcode1998
src/heap.cc:1998: if (!allocation.IsRetry()) {
On 2014/06/24 16:45:51, Igor Sheludko wrote:
> To be uniform:
>   HeapObject* target = NULL;
>   if (allocation.To(&target)) {

Done.

[Hannes Payer (out of office), 2014-06-25 06:29:44]

Committed patchset #3 manually as r21991 (presubmit successful).