Issue 351873005: Remove support for local garden-o-matic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351873005: Remove support for local garden-o-matic (Closed)

Created:
6 years, 5 months ago by eseidel

Modified:
6 years, 5 months ago

Reviewers:
Dirk Pranke, dpranke, abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove support for local garden-o-matic The server version has won. Any features missing from the server version should be added there. BUG=389681 R=abarth@chromium.org, abarth, dpranke Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177141

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -296 lines)			Patch
M	Tools/Scripts/webkitpy/tool/commands/gardenomatic.py	View	2 chunks	+1 line, -25 lines	1 comment	Download
D	Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	View	1 chunk	+0 lines, -135 lines	0 comments	Download
D	Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py	View	1 chunk	+0 lines, -136 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm https://codereview.chromium.org/351873005/diff/1/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py File Tools/Scripts/webkitpy/tool/commands/gardenomatic.py (right): https://codereview.chromium.org/351873005/diff/1/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py#newcode35 Tools/Scripts/webkitpy/tool/commands/gardenomatic.py:35: tool.user.open_url('https://garden-o-matic.appspot.com') If this isn't actually running locally, I ...

6 years, 5 months ago (2014-06-27 21:28:42 UTC) #1

eseidel

6 years, 5 months ago (2014-06-27 21:40:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r177141 (presubmit successful).

Expand Messages | Collapse Messages