Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: Tools/Scripts/webkitpy/tool/commands/gardenomatic.py

Issue 351873005: Remove support for local garden-o-matic (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/servers/gardeningserver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/tool/commands/gardenomatic.py
diff --git a/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py b/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py
index 0a3a703db0e649d4a6de42cff985f5cbfc9c54de..4334ec89288b85e10c1eaf55cc6df4b44c8ee0d3 100644
--- a/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py
+++ b/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py
@@ -24,7 +24,6 @@
from webkitpy.layout_tests.port import builders
from webkitpy.tool.commands.rebaseline import AbstractRebaseliningCommand
-from webkitpy.tool.servers.gardeningserver import GardeningHTTPServer
class GardenOMatic(AbstractRebaseliningCommand):
@@ -32,28 +31,5 @@ class GardenOMatic(AbstractRebaseliningCommand):
help_text = "Command for gardening the WebKit tree."
show_in_main_help = True
- def __init__(self):
- super(GardenOMatic, self).__init__(options=(self.platform_options + [
- self.results_directory_option,
- self.no_optimize_option,
- ]))
-
def execute(self, options, args, tool):
- print "This command runs a local HTTP server that changes your working copy"
- print "based on the actions you take in the web-based UI."
-
- args = {}
- if options.platform:
- # FIXME: This assumes that the port implementation (chromium-, gtk-, etc.) is the first part of options.platform.
- args['platform'] = options.platform.split('-')[0]
- builder = builders.builder_name_for_port_name(options.platform)
- if builder:
- args['builder'] = builder
- if options.results_directory:
- args['useLocalResults'] = "true"
-
- httpd = GardeningHTTPServer(httpd_port=8127, config={'tool': tool, 'options': options})
- self._tool.user.open_url(httpd.url(args))
-
- print "Local HTTP server started."
- httpd.serve_forever()
+ tool.user.open_url('https://garden-o-matic.appspot.com')
Dirk Pranke 2014/06/27 21:28:42 If this isn't actually running locally, I think we
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/servers/gardeningserver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698