Issue 351783005: Merge 175566 "Suspend setTimeout callbacks while dedicated worke..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351783005: Merge 175566 "Suspend setTimeout callbacks while dedicated worke..." (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, falken, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1985/

Visibility:
Public.

More Reviews

Description

Merge 175566 "Suspend setTimeout callbacks while dedicated worke..." > Suspend setTimeout callbacks while dedicated worker execution is paused > > WorkerRunLoop::run shouldn't call SharedTimer::fire when processing debugger tasks. > > BUG=377926 > > Review URL: https://codereview.chromium.org/298383002 TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176821

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, --2 lines)			Patch
A +	LayoutTests/inspector-protocol/debugger/resources/dedicated-worker-suspend-setTimeout.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/workers/WorkerRunLoop.cpp	View	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r176821.

Expand Messages | Collapse Messages