Suspend setTimeout callbacks while dedicated worker execution is paused

Suspend setTimeout callbacks while dedicated worker execution is paused

WorkerRunLoop::run shouldn't call SharedTimer::fire when processing debugger tasks.

BUG=377926
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175566

[pfeldman, 2014-05-28 16:58:11]

lgtm

[yurys, 2014-05-28 17:16:44]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-05-28 17:17:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/298383002/10001

[commit-bot: I haz the power, 2014-05-28 18:42:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/9814)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9266)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9488)

[yurys, 2014-05-28 19:22:23]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-05-28 19:22:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/298383002/30001

[commit-bot: I haz the power, 2014-05-28 21:07:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/9841)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9292)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9517)

[commit-bot: I haz the power, 2014-05-28 21:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 21:51:21]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9310)

[yurys, 2014-05-29 09:01:27]

On 2014/05/28 21:51:21, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9310)

OK, combined with a recent v8 change
(https://codereview.chromium.org/264233005/) this patch causes a dead lock when
we are trying to terminate worker which is running debug loop on pause. This
happens because debug message loop runs with v8::internal::ExecutionAccess lock
being held and attempt to terminate worker triggers call to
v8::V8::TerminateExecution(m_isolate) on the main thread.
v8::V8::TerminateExecution in turn tries to acquire
v8::internal::ExecutionAccess lock. In order to avoid this dead-lock I've added 
WorkerRunLoop::terminateDebugLoop method which ensures we exit debug loop before
v8::V8::TerminateExecution is called. It seems to me though that the issue
should be addressed in v8.

[yurys, 2014-05-29 09:21:32]

I talked to Yang over hangouts, he is going to restore old behavior in v8 when
they are back from holidays on Monday. So the hack with terminateDebugLoop()
will not be needed.

[yurys, 2014-06-04 07:04:15]

On 2014/05/29 09:21:32, yurys wrote:
> I talked to Yang over hangouts, he is going to restore old behavior in v8 when
> they are back from holidays on Monday. So the hack with terminateDebugLoop()
> will not be needed.

V8 issue was fixed in https://code.google.com/p/v8/source/detail?r=21605 so I'm
reverting terminateDebugLoop.

[yurys, 2014-06-04 07:05:50]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-06-04 07:06:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/298383002/60001

[commit-bot: I haz the power, 2014-06-04 08:58:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-06-04 10:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 10:27:20]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[yurys, 2014-06-05 08:38:01]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-06-05 08:38:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/298383002/80001

[commit-bot: I haz the power, 2014-06-05 11:41:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10776)

[commit-bot: I haz the power, 2014-06-05 12:59:48]

Change committed as 175566