Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pdf/BUILD.gn

Issue 351773005: Don't use a version script when linking libpdf.so (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/pdf/pdf_extension_test.cc ('k') | pdf/libpdf.map » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/BUILD.gn
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn
index 916a8310bccc0ee65278241e45230ebf0e8da3eb..5e1f165b1c3fef9dfb4d30147f679f9dd9143572 100644
--- a/pdf/BUILD.gn
+++ b/pdf/BUILD.gn
@@ -88,15 +88,6 @@ shared_library("pdf") {
#},
}
- if (is_linux) {
- # TODO(GYP)
- ## Use a custom version script to prevent leaking the vendor name in
- ## visible symbols.
- #'ldflags': [
- # '-Wl,--version-script=<!(cd <(DEPTH) && pwd -P)/pdf/libpdf.map'
- #],
- }
-
deps = [
"//base",
"//net",
« no previous file with comments | « chrome/browser/resources/pdf/pdf_extension_test.cc ('k') | pdf/libpdf.map » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698