Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Unified Diff: chrome/browser/resources/pdf/pdf_extension_test.cc

Issue 351773005: Don't use a version script when linking libpdf.so (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/pdf_extension_test.cc
diff --git a/chrome/browser/resources/pdf/pdf_extension_test.cc b/chrome/browser/resources/pdf/pdf_extension_test.cc
index 73b6b80743385f4a5ad0672efdf61fab1a5e5632..41a738a495aa4137d6a33ab7261bfce1e5612813 100644
--- a/chrome/browser/resources/pdf/pdf_extension_test.cc
+++ b/chrome/browser/resources/pdf/pdf_extension_test.cc
@@ -85,16 +85,7 @@ IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Basic) {
RunTestsInFile("basic_test.js", false);
}
-// TODO(raymes): This fails with component builds on linux because the plugin
-// plugin crashes due to something related to how the plugin DLL is
-// compiled/linked. crbug.com/386436.
-#if defined(LINUX) && defined(COMPONENT_BUILD)
-#define MAYBE_BasicPlugin DISABLED_BasicPlugin
-#else
-#define MAYBE_BasicPlugin BasicPlugin
-#endif
-
-IN_PROC_BROWSER_TEST_F(PDFExtensionTest, MAYBE_BasicPlugin) {
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, BasicPlugin) {
RunTestsInFile("basic_plugin_test.js", true);
}
« no previous file with comments | « no previous file | pdf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698